Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALCA-DB] Various fixes/improvements for unit test #40971

Closed
wants to merge 1 commit into from
Closed

[ALCA-DB] Various fixes/improvements for unit test #40971

wants to merge 1 commit into from

Conversation

smuzaffar
Copy link
Contributor

Updated unit tests so that they can be run from their own separate directory. Mostly

  • convert <bin ...> to <test....>
  • use full path e.g CMSSW_BASE/src/... instead of ./src/

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Mar 7, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40971/34471

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CondFormats/Common (db, alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@mmusich
Copy link
Contributor

mmusich commented Mar 7, 2023 •
edited
Loading

the name of commit 1cfa9e1 does not belong here (it should actually be in #40972 )

Screenshot from 2023-03-07 09-00-08

(it should be remove unused test file testDropboxMetadataDB.cpp instead)

@smuzaffar
Copy link
Contributor Author

thanks @mmusich , I will update it

@smuzaffar smuzaffar force-pushed the alca-db-fix-unit-test branch from 1cfa9e1 to ad33503 Compare March 7, 2023 08:09
@smuzaffar
Copy link
Contributor Author

something went wrong, let me open a new PR

@smuzaffar smuzaffar closed this Mar 7, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40971/34478

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

Pull request #40971 was updated. @malbouis, @yuanchao, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @ggovi, @sunilUIET, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending code-checks-approved db-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
3 participants
@smuzaffar @cmsbuild @mmusich